Universal-Rom-Tools / Universal-XML-Scraper

Scraper de Rom
195 stars 46 forks source link

Fixed CPU busy-waiting when scraper clients are waiting for messages #74

Closed verybadsoldier closed 7 years ago

Universal-Rom-Tools commented 7 years ago

Thank you Verybadsoldier, Is it ok now with Amiga ?

verybadsoldier commented 7 years ago

Well, I have found out why scraping takes so long for me (and why there are those 60 seconds pauses in the process). It is quite trivial: The main scraper processes all ZIP files but it only sends ROMs that did match to the child-scrapers. And the problem is just that there are so many ROMs that did not match so that there are large pauses until there is again a ROM that was matched. So for example it scans like 100 ROMs and only finds 10 matches then the other 90 ROMs are not send to the child-scrapers and therefore they pause.

Also it turned out that the Amiga ADF ROM list I have send was incomplete, sorry :( Maybe you could add the missing ones? https://github.com/Universal-Rom-Tools/Universal-XML-Scraper/issues/43#issuecomment-264994142

Universal-Rom-Tools commented 7 years ago

Great ^^ It's not a bug :p