Universal-Variability-Language / uvl-lsp

Language server protocol for the Universal Variability Language (UVL)
MIT License
10 stars 4 forks source link

Issue 104: save complete config in file #106

Closed felixrieg closed 1 year ago

felixrieg commented 1 year ago

Fixes: #104

When clicking "Save All" it saves every variable, even the ones that got filled by the smt solver

ThiBruUU commented 1 year ago

I don't have a Save-All button in the configurator. I only see the Save button, which saves your own selection of features.

SaveAll

felixrieg commented 1 year ago

I am starting to believe, that you don't start the extension from the code. It is not sufficient to load a different UVL.exe. You need to start the extension with F5, if you press F5 a new VSCode instance should spawn with all the changes.

felixrieg commented 1 year ago

@ThiBruUU Have you tried it again?

ThiBruUU commented 1 year ago

I tried again. The "Save All" button is visible and works for features in my case. I also tried attributes and they weren't saved correctly when saving with the "Save All" button.

felixrieg commented 1 year ago

@ThiBruUU Do you mean, that the numbers sometimes differ from what you configured? Because I could reproduce this on main as well, so maybe this is a bug for a separate issue Maybe try it on main as well, then we can create a new issue

ThiBruUU commented 1 year ago

yes, exactly. When saving via the normal save, the number attribute was saved correctly. It was only saved with 0 when saving via save all.

felixrieg commented 1 year ago

Now I am confused. Is this a Bug exclusive to this issue or not? If so, could you give a detailed example