search

Universal-Variability-Language / uvl-parser

GNU Lesser General Public License v3.0
10 stars 8 forks source link

Adding javascript basic parser #45

Closed rotkiv93 closed 1 month ago

rotkiv93 commented 2 months ago

In this PR we add the basic files for the parser in the JS language.

Observations:

  1. In the README.md file and also in the package.json files there is a reference to @lbdudc/uvl-parser, this will change when the community decides what should be the name for the registry in NPM.
  2. README.md file should be refined with better descriptions of the steps for installation and usage

Also, the parser was tested using all the UvlHub repositories, with a success rate of 1428 of 1452 total uvl files. Note that the errors that we got in the test suitcase were discussed with the uvlhub team, and they are not errors in the parser, but rather some uvl is not correct.

SundermannC commented 2 months ago

Hi @rotkiv93, thanks a lot for your pull request. Having a parser variant for JavaScript seems very valuable. :) It seems like you are still actively committing to the source branch. Can you notify us when the branch is ready for a review or is it already? Best, Chico

jagalindo commented 2 months ago

Howdy Chico, I'm currently providing himn guidannce so the pr could be accepted and a javascript version of the parseer online. Hopefully this afternoon we finish it.

jagalindo commented 1 month ago

i'm squashing this pr. Already checked it out. The only missing point was the conventional commits which is going to be solved by the squash