UniversalDataTool / collaboration-server

Collaboration Server for use with Universal Data Tool
5 stars 6 forks source link

Endpoint unreachable #24

Open CedricProfessionnel opened 3 years ago

CedricProfessionnel commented 3 years ago

Steps to reproduce :

Why its happen : catch the wrong endpoint on the server

image

seveibar commented 3 years ago

I'm not sure this issue has enough detail, getSample does work sometimes- otherwise the collaborative sessions wouldn't work at all.

What commands were done to create the sample?

CedricProfessionnel commented 3 years ago

This is my test no change in setSample getSample

new CollaborationServer() //no param .createNewSession //Necessary to return true on isReady .isReady() // wait until return true .setDataset() //send a new dataset as a param var testSample = { _id: "test" } .setSample("sdjz2g1qa", testSample) //"sdjz2g1qa" is created in the previous dataset .getSample("sdjz2g1qa") || .getSample("test") // I tried both

.

CedricProfessionnel commented 3 years ago

Remark : The error message above is from endpoints/get-session.js and i want to catch endpoints/get-sample.js

CedricProfessionnel commented 3 years ago

I find i did add an "s" ( https://collaboration.universaldatatool.com/api/session/id1/sample/sdjz2g1qa => https://collaboration.universaldatatool.com/api/session/id1/samples/sdjz2g1qa ) in the path but without i get : image

seveibar commented 3 years ago

oh interesting! So it seems we have a path typo :/

CedricProfessionnel commented 3 years ago

I don't know it could be since both result in error but if i check router.js it don't seem to have an "s"