search

UniversalDataTool / react-image-annotate

Create image annotations. Classify, tag images with polygons, bounding boxes or points.
MIT License
406 stars 178 forks source link

Added typescript and update old dependencies to React v.18 #237

Open oleg-yasenytsky opened 7 months ago

AlecDusheck commented 6 months ago

Thanks alot for doing this <3

wesmorishita commented 6 months ago

Any chance this could be reviewed and merged in?

alexschultz commented 3 months ago

@seveibar any chance you can look at this?

seveibar commented 3 months ago

Hey guys, taking a look

AlecDusheck commented 3 months ago

Would it be possible to toss this in a branch as-is and add a note in the README saying experimental React 18 support is a work in progress?

oleg-yasenytsky commented 3 months ago

If anyone need package with this pull, i deploy it npm.js https://www.npmjs.com/package/@idapgroup/react-image-annotate

seveibar commented 3 months ago

Would it be possible to toss this in a branch as-is and add a note in the README saying experimental React 18 support is a work in progress?

I'm eager to merge this, but I think my comments are pretty reasonable, for a project this old its good to make sure you don't lose testing surface area, and some of the other changes would misdirect the user, eg the README wouldn't link to user to the npm package published by this repo.

To clarify: I'm very eager to merge and make people maintainers