search

UniversalDataTool / universal-data-tool

Collaborate & label any type of data, images, text, or documents, in an easy web interface or desktop app.
https://universaldatatool.com
MIT License
1.92k stars 187 forks source link

Waveform fix #518

Open tylersuchan opened 2 years ago

tylersuchan commented 2 years ago

Hello,

I would like to request either a solution to my problem or the opportunity to create a solution to the problem I'm having...

I require the ability to use this library for Audio Annotation, in a very similar way that both the Image Segmentation and Video Segmentation work within this app. I've noticed through trial and error that one can use the "video segmentation" module and insert a .mp3 file, however during playback the area where a video normally spawns there is a blank canvas. This makes sense, since there's no visual component.

I would like to, instead, have some sort of audio sinewave that would allow a user to make annotations to it. Wavesurfer.js is exactly the type of visual I was thinking of. I already have successfully created a React component that wraps this library, and now want a means to place it within the canvas that videos normally reside. However, I can't find a way to do this with the UniversalSampleEditor component.

I also noticed that within the repo, a Waveform component exists, but it doesn't seem to be hooked up to UniversalSampleEditor

To wrap all of this up, has anyone else run into the problem I have and found an elegant solution? If not, I'm requesting making a branch/PR to fully integrate the Waveform component within UDT to get audio wave visuals into the tool.

Thank you!

minelminel commented 2 years ago

+1, as I've also ran into this same problem before. I think this would be a worthwhile addition to an already excellent toolkit.

seveibar commented 2 years ago

huh this should already be possible (we made https://github.com/UniversalDataTool/react-time-series and integrated it into this)

tylersuchan commented 2 years ago

It seems that the "Wave" examples from this tool, which is (I think) what I'm looking for, aren't working. https://universaldatatool.com/react-time-series/index.html?path=/docs/wave--single-curve I understand that this issue is outside the scope of this project, but I figured I'd make you aware. Plus, it would be nice to see how it works before trying to integrate it myself.