UniversalDependencies / UD_English-GUM

Other
32 stars 4 forks source link

Commas used both as separators in Bridge and within Wikification #12

Closed martinpopel closed 3 years ago

martinpopel commented 3 years ago

Comma is used to separate bridging links in Bridge, e.g.

However, commas can be also part of Entity IDs when wikification is included. Parsing Bridge is thus ambiguous, e.g.:

My suggestion is to escape all commas in Entity IDs with %2C (the URL will be still valid).

amir-zeldes commented 3 years ago

Ooh, nice catch! Yes, we are already using URL encoding for parentheses, just forgot about this one. Will fix.

amir-zeldes commented 3 years ago

Resolved in 6c0cd45 and UniversalDependencies/UD_English-GUMReddit@ef6a885