UniversalDependencies / UD_English-GUM

Other
32 stars 4 forks source link

I'd -> I would -> "will" for lemma #55

Closed AngledLuffa closed 1 year ago

AngledLuffa commented 2 years ago

In the test set, I think this should be treated as "would" and not "will". Elsewhere "would" has the lemma "would"

# sent_id = GUM_conversation_lambada-24
# text = So, every once in a while I'd get up and dance, and it's like, when I'd come back, I mean there was some guy there, sitting in my chair.
8-9     I'd     _       _       _       _       _       _       _       _
8       I       I       PRON    PRP     Case=Nom|Number=Sing|Person=1|PronType=Prs      10      nsubj   10:nsubj|13:nsubj       Entity=(1-person-giv:inact-1-ana)
9       'd      will    AUX     MD      VerbForm=Fin    10      aux     10:aux|13:aux   _
10      get     get     VERB    VB      VerbForm=Inf    0       root    0:root  _
11      up      up      ADP     RP      _       10      compound:prt    10:compound:prt _
12      and     and     CCONJ   CC      _       13      cc      13:cc   Discourse=joint-sequence_m:39->38:0
13      dance   dance   VERB    VB      VerbForm=Inf    10      conj    10:conj:and     SpaceAfter=No
21-22   I'd     _       _       _       _       _       _       _       _
21      I       I       PRON    PRP     Case=Nom|Number=Sing|Person=1|PronType=Prs      23      nsubj   23:nsubj        Entity=(1-person-giv:act-1-ana)
22      'd      will    AUX     MD      VerbForm=Fin    23      aux     23:aux  _
23      come    come    VERB    VB      VerbForm=Inf    29      advcl   29:advcl:when   _
24      back    back    ADV     RB      Degree=Pos      23      advmod  23:advmod       SpaceAfter=No
amir-zeldes commented 2 years ago

Will fix

AngledLuffa commented 1 year ago

Fixed in 2.11

amir-zeldes commented 1 year ago

Thanks for cleaning these issues up!