Closed AngledLuffa closed 10 months ago
A past PR on the Pronouns dataset had removed its genitive cases:
https://github.com/UniversalDependencies/UD_English-Pronouns/pull/5
but there are quite a few Case=Gen
in EWT
Also, the lemmas of yours
don't agree with the current PRON table:
https://universaldependencies.org/en/pos/PRON.html
although further inspection of that table makes me think none of these instances should be Case=Gen
, rather than all of them
The root cause is that this is an xpos tag error - PRP$ should be PRP. Will fix, thanks!
Didn't even look at that, nice catch. Still, might be worth rechecking the features as well
The features are auto generated based on the manual annotations, and in this case the culprit is the xpos tag (and the lemma would have tripped the validator if xpos had been correct)
What I mean is maybe none of them should be Case=Gen
according to the PRON page
Indeed, as long as they are not xpos=PRP$
, they will also not be Case=Gen
:
https://github.com/amir-zeldes/gum/blob/master/_build/utils/ud_morph.ini#L59
The first couple examples in this thread were Case=Gen
, but perhaps you mean it will change now
Yup, that will change automatically. Almost all FEATS in GUM are refreshed and generated automatically with each release, so there is no need to correct them manually.
# sent_id = GUM_vlog_pizzeria-62 # text = You want onions on yours? 5 yours yours PRON PRP$ Case=Gen|Number=Sing|Person=2|Poss=Yes|PronType=Prs 2 obl 2:obl:on Entity=(25-person-giv:act-cf1-1-ana)|SpaceAfter=No
Here yours should not be labled Case=Gen, unless the adposition takes genitive goverment. Lemmatization looks correct if we consider function. @amir-zeldes
Here yours should not be labled Case=Gen
Indeed, and now that the underying xpos has been changed to PRP it will not happen - as soon as FEATS are regenerated, it will not be Case=Gen anymore.
Lemmatization looks correct if we consider function
No, it was decided to split these and the personal pronouns into exactly two lemmas - the attributive possessive form for all the possessives (your, yours -> your) and the nominative personal pronoun for the rest (you), so the correct lemma is "your" (as now corrected upstream). See the whole specification here:
Two examples of
yours
are genitive:This one is different: