search

UniversalDependencies / UD_Faroese-OFT

Other
1 stars 2 forks source link

Fix Validation Issues (#10) #11

Closed mr-martian closed 2 years ago

ftyers commented 2 years ago

Thanks @mr-martian ! @dan-zeman can you check this out?

dan-zeman commented 2 years ago

I suspect that the nsubj:outer on line 2031 is wrong.

Tað eru 10 býir í Oskarshamns kommunu.

With the help of Google Icelandic (:-)) translator, I understand it as "There are 10 villages in Oskarshamn municipality." It does not sound like the typical construction for which nsubj:outer was designed. And the previous sentence

Tað eru átta býir og bygdir í Hultsfreds kommunu.

is very similar and does not need nsubj:outer; it uses expl instead.

Finally, as we are already looking at these sentences, I believe that the preposition í should be attached to kommunu, not to the genitive PROPN that modifies it.

dan-zeman commented 2 years ago

I went ahead and fixed the file (08beffd4781caea1bf95b97e5fa133d0271f235c) along the lines of my previous post. I need the file to be at least back to LEGACY status, i.e., no new unknown deprel errors.

mr-martian commented 2 years ago

On the nsubj/expl I was going solely based on the trees and for the preposition attachment I just went too quickly and missed the second noun.