rebase #143 and #144 - Githubissues

UniversalDependencies / UD_Irish-IDT

Irish data

Other

6 stars 7 forks source link

rebase #143 and #144 #145

Closed jimregan closed 2 years ago

dan-zeman commented 2 years ago

Sorry, I am not sure what change you did but Github still says

jimregan wants to merge 2 commits into UniversalDependencies :master from jimregan:asd

A pull request can only work if it is both

based on the dev branch and
asking to be merged into the dev branch

(And then I will simply leave it here for the maintainers of the Irish treebank to decide whether to accept it.)

jimregan commented 2 years ago

Mea culpa; I rebased the commits on dev, forgot to also change it in the pull request interface. I had assumed that the problem was that they were based on master, which has commits that dev doesn't, because it's otherwise trivial to change the target branch in the interface. Assuming the pull request hasn't been closed in the meantime, that is.