The validator was reporting 167 warnings regarding use of flat:foreign. This patch resolves all of those. It also includes various other fixes that I made along the way, but hopefully nothing controversial — sorry to mix it all up together.
In terms of the flat:foreign stuff, the three options for handling "foreign" material are laid out here:
I followed "Option 2" in most cases which seems to make the most sense, and is closest to the way things were annotated already.
Option 3 was more appropriate in a small number of cases where the English text was something like a full quoted phrase vs. a proper name that played a syntactic role in the otherwise Irish sentence. See for example the quoted phrase "that general Jail-Deliverer" in sent_id=85, or "Kill me, I Love You!" in sent_id=201.
The validator was reporting 167 warnings regarding use of flat:foreign. This patch resolves all of those. It also includes various other fixes that I made along the way, but hopefully nothing controversial — sorry to mix it all up together.
In terms of the flat:foreign stuff, the three options for handling "foreign" material are laid out here:
https://universaldependencies.org/foreign.html
I followed "Option 2" in most cases which seems to make the most sense, and is closest to the way things were annotated already.
Option 3 was more appropriate in a small number of cases where the English text was something like a full quoted phrase vs. a proper name that played a syntactic role in the otherwise Irish sentence. See for example the quoted phrase "that general Jail-Deliverer" in sent_id=85, or "Kill me, I Love You!" in sent_id=201.