search

UniversalDependencies / UD_Portuguese-Bosque

This Universal Dependencies (UD) Portuguese treebank.
Other
48 stars 11 forks source link

Fixing errors Bosque-UD 2.5 #274

Closed alvelvis closed 4 years ago

alvelvis commented 4 years ago

@arademaker , is it easy for you to check how many errors were fixed in this PR? (no problem if you can't)

arademaker commented 4 years ago

Hi @alvelvis ,

% grep -i FAILED report-bosque-alvelvis-3.log | awk 'BEGIN {sum=0} {sum=sum+$5} END{print sum}'
3007

the last one was 3048. Less 41 errors.

% grep -i FAILED report-bosque-alvelvis-3.log | wc -l
1042

the last one was 1053. Less 11 sentences.

arademaker commented 4 years ago

Do you want me to accept this PR?

alvelvis commented 4 years ago

Yes, please. I will be sending another PR soon.

arademaker commented 4 years ago

Hi @alvelvis , could you please move the scripts from scriptsElvis directory to the scripts directory. If necessary, we can reorganize the scripts into subdirectories named after the method/approach. Let us avoid put our names in things in the repo please, this is a collaborative work.

alvelvis commented 4 years ago

Sure, @arademaker , I'll do that, but soon I will be deleting them as they are only meant to be used by me. I added them to repo just so that I could use them in different computers.