search

UniversalDependencies / UD_Portuguese-Bosque

This Universal Dependencies (UD) Portuguese treebank.
Other
50 stars 12 forks source link

Fixed newly indicated validation errors #407

Closed dan-zeman closed 2 years ago

dan-zeman commented 2 years ago

@arademaker : I am going to merge this into dev so that the data stays valid for UD 2.10. You may want to integrate them into workbench.

arademaker commented 2 years ago

Oh , I would prefer first work in the workbench … why not an PR to there?

dan-zeman commented 2 years ago

Sorry for that. I wanted to create a PR to workbench as well but I was surprised to learn from Github that the two branches have disjoint sets of commits.

EDIT: I now see that workbench has a totally different file-folder structure, so a PR with my quick fixes in the to-be-released CoNLL-U files would not work anyway. (But those are the files where the on-line validator reports the errors.)

arademaker commented 2 years ago

Yes, they do. Workbench has a complete different files organization and I have a script to push to dev

arademaker commented 2 years ago

Ok I will try to apply the changes in the workbench . Please in the future just open an issue and I solve directly in the workbench

dan-zeman commented 2 years ago

Thank you. Will try to remember this for the future releases.

In the meantime, I identified that my edits were in these three sentences:

arademaker commented 2 years ago

Thank you

arademaker commented 2 years ago

Everything updated. But now goestwith vs word-with-space is confusing to me..