solves issue #3 - Githubissues

UniversalDependencies / UD_Portuguese-PUD

Parallel Universal Dependencies.

Other

5 stars 3 forks source link

solves issue #3 #6

Closed arademaker closed 3 years ago

arademaker commented 3 years ago

this solves issue #3

arademaker commented 3 years ago

@dan-zeman sorry for the mistakes with the branches. Hoppe that now everything is right. The issue-3 branch is based on dev and this PR is to merge into dev.

arademaker commented 3 years ago

one extra commit to solve #2 too.

arademaker commented 3 years ago

@dan-zeman I will wait you merge this PR, or confirm that I can make it myself, before solving the remaining issue #1

arademaker commented 3 years ago

Can I accept it now?

dan-zeman commented 3 years ago

Looks good to me now :-)

dan-zeman commented 3 years ago

... but it looks like I overlooked a text mismatch error :-( Too bad that we cannot run the validator on pull requests before merging them.

dan-zeman commented 3 years ago

Fixed in 5191c52173d00b9d6cebf211dd66ab3e72247ad9