search

UniversalDevicesInc / pg3-python-interface

PG3 Python Interface
MIT License
0 stars 1 forks source link

check_profile() should use an interface specific data store for version #2

Open bpaauwe opened 4 years ago

bpaauwe commented 4 years ago

By trying to store the profile version in the same customdata array that is used by the node server, there's a high risk that it will get overwritten and not work as intended.

If the node server doesn't take care to save the profile version and simply calls saveCustomData() with it's own list of custom data, the profile version will be overwritten.

There should be a separate list of data items that are managed by the interface code and these shouldn't be exposed to the node server.

If profile version is something the node server needs access to, there should be a property with this info available.

jimboca commented 4 years ago

Agree with all, this should get better with V3 with the DB changes