Closed urmahp closed 2 years ago
Rebased onto current master so all CI step should succeed.
Base: 41.13% // Head: 51.29% // Increases project coverage by +10.16%
:tada:
Coverage data is based on head (
5f4680b
) compared to base (f31f998
). Patch coverage: 95.90% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks good to me. Moving the setup into the fixtures is a debatable feature, so I'll approve this, but will only merge this after discussing that topic.
I think it would be a good idea to make the setup part of the fixture, since it is identical for all the tests, so I will have a look at that.
Squashed to re-trigger code-cov report.
Just for clarity: This is currently being held back as @urmahp wanted to move code to the test fixture. Once this is done, this should be ready to merge.
Let's rebase this once #107 got merged.