Closed urrsk closed 1 year ago
Base: 63.34% // Head: 74.12% // Increases project coverage by +10.78%
:tada:
Coverage data is based on head (
d5fa901
) compared to base (1ed6576
). Patch coverage: 66.97% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@urrsk I've included most of your comments from https://github.com/urrsk/Universal_Robots_Client_Library/pull/1 and I think I would be happy with the state this is in. I tend to disagree with https://github.com/urrsk/Universal_Robots_Client_Library/pull/1#discussion_r1028017404
This feels like hitting the "using exceptions as control flow is an anti-pattern" too hard. That might be a more general question though, how we would like to structure this library.
Merging despite failing pipeline on humble, because of #132.
This PR started with adding a example for getting the calibration info out from the primary interface. Then I want it to run in the CI for continue test that it could run. After I added a step running the examples, I realised that the other examples need some adjustments, including some calls through the dashboard server, to turn the Simulated robot into run mode. Therefore includes this PR also functionalities to run Dashboard command for this purpose, just like it is made in the ROS drivers. In addition, the CI also was update to use the docker imagel