UniversalRobots / Universal_Robots_Client_Library

A C++ library for accessing the UR interfaces that facilitate the use of UR robotic manipulators by external applications.
Apache License 2.0
117 stars 88 forks source link

Catch Exception by reference and not by value #130

Closed fmauch closed 1 year ago

fmauch commented 1 year ago

In general this is a good idea and it will silence a compiler warning.

codecov[bot] commented 1 year ago

Codecov Report

Base: 63.41% // Head: 63.29% // Decreases project coverage by -0.12% :warning:

Coverage data is based on head (f91d9c2) compared to base (07969f0). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ========================================== - Coverage 63.41% 63.29% -0.13% ========================================== Files 89 89 Lines 2974 2975 +1 Branches 309 310 +1 ========================================== - Hits 1886 1883 -3 - Misses 929 932 +3 - Partials 159 160 +1 ``` | [Impacted Files](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots) | Coverage Δ | | |---|---|---| | [src/ur/dashboard\_client.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-c3JjL3VyL2Rhc2hib2FyZF9jbGllbnQuY3Bw) | `0.00% <0.00%> (ø)` | | | [src/control/trajectory\_point\_interface.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-c3JjL2NvbnRyb2wvdHJhamVjdG9yeV9wb2ludF9pbnRlcmZhY2UuY3Bw) | `71.79% <0.00%> (-7.70%)` | :arrow_down: | | [tests/test\_tcp\_server.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-dGVzdHMvdGVzdF90Y3Bfc2VydmVyLmNwcA==) | `98.47% <0.00%> (-0.76%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.