UniversalRobots / Universal_Robots_Client_Library

A C++ library for accessing the UR interfaces that facilitate the use of UR robotic manipulators by external applications.
Apache License 2.0
117 stars 88 forks source link

Changed num_retries from static to an unsigned int #136

Closed urmahp closed 1 year ago

urmahp commented 1 year ago

The num_retries wouldn't be reset within each function, but it will now so the correct number of retries is performed in each function, before throwing an exception.

codecov[bot] commented 1 year ago

Codecov Report

Base: 74.09% // Head: 74.55% // Increases project coverage by +0.46% :tada:

Coverage data is based on head (31f2242) compared to base (09adab9). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #136 +/- ## ========================================== + Coverage 74.09% 74.55% +0.46% ========================================== Files 91 89 -2 Lines 3462 3490 +28 Branches 359 367 +8 ========================================== + Hits 2565 2602 +37 + Misses 680 668 -12 - Partials 217 220 +3 ``` | [Impacted Files](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots) | Coverage Δ | | |---|---|---| | [src/rtde/rtde\_client.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-c3JjL3J0ZGUvcnRkZV9jbGllbnQuY3Bw) | `55.97% <100.00%> (+1.67%)` | :arrow_up: | | [tests/test\_primary\_parser.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-dGVzdHMvdGVzdF9wcmltYXJ5X3BhcnNlci5jcHA=) | `81.81% <0.00%> (-8.19%)` | :arrow_down: | | [include/ur\_client\_library/comm/stream.h](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-aW5jbHVkZS91cl9jbGllbnRfbGlicmFyeS9jb21tL3N0cmVhbS5o) | `88.88% <0.00%> (-7.12%)` | :arrow_down: | | [include/ur\_client\_library/rtde/rtde\_writer.h](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-aW5jbHVkZS91cl9jbGllbnRfbGlicmFyeS9ydGRlL3J0ZGVfd3JpdGVyLmg=) | `75.00% <0.00%> (-5.00%)` | :arrow_down: | | [tests/test\_rtde\_parser.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-dGVzdHMvdGVzdF9ydGRlX3BhcnNlci5jcHA=) | `80.45% <0.00%> (-3.45%)` | :arrow_down: | | [include/ur\_client\_library/queue/atomicops.h](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-aW5jbHVkZS91cl9jbGllbnRfbGlicmFyeS9xdWV1ZS9hdG9taWNvcHMuaA==) | `66.66% <0.00%> (-3.08%)` | :arrow_down: | | [tests/test\_rtde\_client.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-dGVzdHMvdGVzdF9ydGRlX2NsaWVudC5jcHA=) | `80.85% <0.00%> (-0.68%)` | :arrow_down: | | [src/log.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-c3JjL2xvZy5jcHA=) | `73.80% <0.00%> (-0.61%)` | :arrow_down: | | [src/control/script\_command\_interface.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-c3JjL2NvbnRyb2wvc2NyaXB0X2NvbW1hbmRfaW50ZXJmYWNlLmNwcA==) | `11.11% <0.00%> (-0.21%)` | :arrow_down: | | [src/ur/dashboard\_client.cpp](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-c3JjL3VyL2Rhc2hib2FyZF9jbGllbnQuY3Bw) | `61.22% <0.00%> (-0.16%)` | :arrow_down: | | ... and [21 more](https://codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/136/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.