Closed urmarp closed 3 months ago
Base: 74.09% // Head: 75.53% // Increases project coverage by +1.44%
:tada:
Coverage data is based on head (
1d13676
) compared to base (09adab9
). Patch coverage: 68.91% of modified lines in pull request are covered.:exclamation: Current head 1d13676 differs from pull request most recent head 3cd736a. Consider uploading reports for the commit 3cd736a to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@urmarp this would be easier to review if these were multiple commits.
Before reviewing this any further: Could you please elaborate what you have done? What is the handler concept and why did you add this?
Again, splitting this into multiple commits (maybe with commit messages going into more detail) might make things a lot clearer.
I have split the commit into multiple commits and tried to explain the thoughts behind the changes.
Added message handlers for the messages from the primary interface. These handlers save the data from the latest message of each type, which can then be accessed through the primary client. The handlers also enable the possibility to handle the data differently for each message. The primary client can through its consumer get the message handlers and from the message handlers get the latest message of each type.
Closing this in favor of #186
Improved primary interface, this includes following changes:
Added message handlers for messages received through primary client
Changed primary pipeline and full driver example
Added datatype: vector6f_t and vector6uin8_t
Added parsing of vector6f_t
Changed timeout in producer
Added parsing of more messages from primary interface
Added calibration check in constructor of primary client
Added calibration checksum to urdriver constructor
Added test for primary client and primary parser
Added funtionality to set robot as simulated or real
Added wait in full driver example