search

UniversalRobots / Universal_Robots_Client_Library

A C++ library for accessing the UR interfaces that facilitate the use of UR robotic manipulators by external applications.
Apache License 2.0
117 stars 88 forks source link

Add a cmake option to activate address sanitizers #146

Closed fmauch closed 1 year ago

fmauch commented 1 year ago

In an effort to track down memory issues, I started activating address sanitizers on the urcl. I think, we should activate them by default inside CI in order to spot issues early on.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.42 :warning:

Comparison is base (a1e514c) 70.62% compared to head (9f852b8) 70.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #146 +/- ## ========================================== - Coverage 70.62% 70.21% -0.42% ========================================== Files 69 69 Lines 2526 2521 -5 Branches 321 321 ========================================== - Hits 1784 1770 -14 - Misses 562 567 +5 - Partials 180 184 +4 ``` | [Impacted Files](https://app.codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots) | Coverage Δ | | |---|---|---| | [include/ur\_client\_library/rtde/rtde\_package.h](https://app.codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-aW5jbHVkZS91cl9jbGllbnRfbGlicmFyeS9ydGRlL3J0ZGVfcGFja2FnZS5o) | `100.00% <ø> (ø)` | | | [include/ur\_client\_library/comm/bin\_parser.h](https://app.codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/146?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-aW5jbHVkZS91cl9jbGllbnRfbGlicmFyeS9jb21tL2Jpbl9wYXJzZXIuaA==) | `89.55% <100.00%> (+0.32%)` | :arrow_up: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/146/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

fmauch commented 1 year ago

@RobertWilbrandt I've updated the PR using targeted compile options. This should now probably be fine for merging