codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01% :tada:
Comparison is base (
03d879e) 70.32% compared to head (4c04b88) 70.33%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #170 +/- ## ========================================== + Coverage 70.32% 70.33% +0.01% ========================================== Files 69 69 Lines 2534 2535 +1 Branches 324 324 ========================================== + Hits 1782 1783 +1 - Misses 563 565 +2 + Partials 189 187 -2 ``` | [Files Changed](https://app.codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots) | Coverage Δ | | |---|---|---| | [src/helpers.cpp](https://app.codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/170?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots#diff-c3JjL2hlbHBlcnMuY3Bw) | `40.90% <100.00%> (-11.48%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/UniversalRobots/Universal_Robots_Client_Library/pull/170/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UniversalRobots):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Based on https://github.com/UniversalRobots/Universal_Robots_ROS_Driver/issues/654
I agree that an error message seems too hard here, as you are still able to operate the driver even if you are not setup for FIFO scheduling. We also shouldn't error out twice, if we cannot change the scheduling parameters the second check seems redundant.