Closed fmauch closed 11 months ago
Patch coverage is 90.00%
of modified lines.
:loudspeaker: Thoughts on this report? Let us know!.
Going back to draft because of failing tests
@urmahp I found one more flaw when passing reconnection time to the socket. The tests were succeeding but taking too long, since the default timeout is 10 seconds. I added a limit of 1.5 seconds (since the connection should take 2*500ms+overhead). This way we can make sure that the set timeout is actually being used.
Edit: Seeing that two tests now fail because of taking too long. Going to continue on this tomorrow.
@urmahp If you could give it one more review, that would be great. I didn't clean up the commits since this seems to confuse coverage.io quite a lot. I'll do that right before merging.
This continues #141 and fixes #140.
ToDo: