UniversalRobots / Universal_Robots_ROS2_Description

ROS2 URDF description for Universal Robots
BSD 3-Clause "New" or "Revised" License
113 stars 107 forks source link

Tag for binary release #19

Closed fmauch closed 2 years ago

fmauch commented 2 years ago

We should decide for a point when we want to make a binary release. Before, we should decide on #17 and merge #3. Then, we should tag and release a first version. I would aim for Foxy and galactic, as for Rolling, we might want to wait for #16, first. Any opinions on that @destogl?

Target distributions

Merge / decide open PRs

destogl commented 2 years ago

I think this is a good strategy. Although, we should also consider merging #16 since I back ported the FakeSystem functionality for it to galactic (ros-controls/ros2_control#634). This is not released yet, but it should be with the next galactic.

So, I would try to go for the release. Maybe we should try all three of them immediately. Before that, we should probably make changes for galactic. There is one more change for rolling that will not be back ported to galactic, and this is initial_value parameter (see comments in: ros-controls/ros2_control#635).

As of foxy, we should probably not release this but then rather from the other repository (foxy branch of Driver has ur_description in there). TBH, I would skip foxy release because any direction we choose it will be complicated and will need a lot of work, but I believe that the impact is limited there, especially because of new LTS coming out very soon. I would rather focus our effort to get better driver for Humble then spend time on code management to release to foxy.

fmauch commented 2 years ago

Thanks for the heads-up!

I agree on Foxy, removed it from the list but added rolling and humble instead. Then, we merge #16, fork out for galactic and remove the initial_value from that?

fmauch commented 2 years ago

Requested a release repo: https://github.com/ros2-gbp/ros2-gbp-github-org/issues/21

fmauch commented 2 years ago

Release triggered

fmauch commented 2 years ago

Closing as release is done since a while