search

UniversalRobots / Universal_Robots_ROS2_Description

ROS2 URDF description for Universal Robots
BSD 3-Clause "New" or "Revised" License
110 stars 107 forks source link

fake_components -> mock_components #37

Closed Abishalini closed 1 year ago

Abishalini commented 2 years ago

This was caused by a change in ros2_control: https://github.com/ros-controls/ros2_control/commit/1967cfa179248ce2e72f4f974f20d6e19fe56da4

I need this change to work with fake hardware.

fmauch commented 1 year ago

Thank you for that PR. I'll have a look into which versions this actually affects and then decide how to proceed further.

Edit: Looks like we need to branch out for galactic before merging this.

fmauch commented 1 year ago

@Abishalini what kind of error did you experience? I've tried to reproduce the problems you had as I would have liked to catch that using a test, but I noticed that fake_hardware still seems to be functioning, which is no surprise if we take a look at https://github.com/ros-controls/ros2_control/blob/1967cfa179248ce2e72f4f974f20d6e19fe56da4/hardware_interface/fake_components_plugin_description.xml.