search

UniversalRobots / Universal_Robots_ROS2_Description

ROS2 URDF description for Universal Robots
BSD 3-Clause "New" or "Revised" License
110 stars 107 forks source link

Change `load_yaml` to `xacro.load_yaml` after former was deprecated #43

Closed aditya2592 closed 1 year ago

aditya2592 commented 1 year ago

Avoids following error and allows URDF to load. Without this change, UR URDF can no longer be loaded into ROS packages

warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.
warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.
warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.
warning: Using load_yaml() directly is deprecated. Use xacro.load_yaml() instead.
fmauch commented 1 year ago

In principle I do agree, although I wouldn't draw the picture as dramatically, since this is "only" a warning. I am a bit confused by the failing test, though.

Edit: This seems to be an issue with pre-2.0.8. Since 2.0.8 is already synced to humble and will be synced to rolling in the next release, I'll merge this nevertheless.

aditya2592 commented 1 year ago

Yes. This is a warning but after the humble sync on 11/2, this was preventing us from loading URDF