Revert "Switch fake to mock for ros2_control updates (#77)"

UniversalRobots / Universal_Robots_ROS2_Description

ROS2 URDF description for Universal Robots

BSD 3-Clause "New" or "Revised" License

105 stars 103 forks source link

Revert "Switch fake to mock for ros2_control updates (#77)" #78

Closed fmauch closed 1 year ago

fmauch commented 1 year ago

This reverts commit aedef36301d9da446d0e255a2c2d6dc9c743378f that was done based on #76

Since it was only a deprecation warning, there is no need to break API on humble.

@sea-bass just to clarify: On humble using fake_hw should not break anything, but it should only raise a deprecation warning. So, since switching to mock in our description files would actually introduce an unnecessary API incompatibility, hence I'd like to revert this.

Edit: Iron should follow that.

sea-bass commented 1 year ago

Agreed on not introducing breaking APIs to Humble.

I was on Humble and these changes resolved a segfault about missing state interfaces for me... but maybe there was something else going on.

As long as reverting these changes keeps mock hardware examples working on Humble in you guys' testing, that should be OK and I will keep chasing the problem on my side.