search

UniversalRobots / Universal_Robots_ROS2_Driver

Universal Robots ROS2 driver supporting CB3 and e-Series
BSD 3-Clause "New" or "Revised" License
408 stars 212 forks source link

Fix for forward_velocity_controller test (backport #1076) #1091

Closed mergify[bot] closed 3 weeks ago

mergify[bot] commented 3 weeks ago

This PR aims to fix the test for the forward_velocity_controller: basically the related config file was missing the publish_topic parameter. Now when the controller is active, the velocity goals are correctly sent by launching test_forward_velocity_controller.launch.py.

This is an automatic backport of pull request #1076 done by Mergify.

mergify[bot] commented 3 weeks ago

Cherry-pick of b422d4931983c682866efcd71dad942f645ac9a1 has failed:

On branch mergify/bp/humble/pr-1076
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit b422d49.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   ur_robot_driver/config/test_velocity_goal_publishers_config.yaml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   ur_robot_driver/launch/test_forward_velocity_controller.launch.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally