search

UniversalRobots / Universal_Robots_ROS2_Driver

Universal Robots ROS2 driver supporting CB3 and e-Series
BSD 3-Clause "New" or "Revised" License
436 stars 227 forks source link

Check why C++17 is used and if it is possible to use C++14 for the foxy release. #129

Closed destogl closed 2 years ago

destogl commented 3 years ago

The binary build seems to fail as the released version uses the boost branch of the library instead of the master branch. Therefore, it doesn't export a c++17 dependency and therefore the build fails on all c++17 functionalities from this driver.

I decided to release the foxy version also from the boost branch, as the [target platform specification}(https://www.ros.org/reps/rep-2000.html#foxy-fitzroy-may-2020-may-2023) specifies c++14 for Foxy as minimum requirement.

It might be either a good idea to add the c++17 requirement to this driver or release the library's foxy package from the master branch. Any opinions?

_Originally posted by @fmauch in https://github.com/UniversalRobots/Universal_Robots_ROS2_Driver/issues/125#issuecomment-854532741_

destogl commented 3 years ago

After discussion, we should go with C++17 to avoid boost dependency. Consequences of this decision should be considered.

fmauch commented 3 years ago

Then I'll release the next foxy library version from the master branch. There will be a new release with the Cartesian interface pretty soon, anyway.

fmauch commented 3 years ago

I triggered a new release for Foxy from the master branch (see https://github.com/ros/rosdistro/pull/29954)

fmauch commented 3 years ago

@destogl this could probably get closed, right?

fmauch commented 2 years ago

Closing this due to seemingly irrelevance.