UniversalViewer / universalviewer

A community-developed open source project on a mission to help you share your πŸ“šπŸ“œπŸ“°πŸ“½οΈπŸ“»πŸ—Ώ with the 🌎
http://universalviewer.io
Other
500 stars 191 forks source link

pressing bookmark button leads to error in the console #535

Open nicolasfranck opened 6 years ago

nicolasfranck commented 6 years ago

UV version:

 universalviewer@2.0.1

I'm submitting a:

Current behavior:

If you press the bookmark button an error occurs in the console:

Uncaught TypeError: Cannot set property 'path' of undefined
    at Boolean.<anonymous> (helpers.js:116)
    at UVComponent.BaseComponent.fire (base-component.js:41)
    at Extension.BaseExtension.fire (BaseExtension.js:539)
    at Object.<anonymous> (BaseExtension.js:149)
    at Object.dispatch (offline.js:3)
    at Object.r.handle (offline.js:3)
    at Object.trigger (offline.js:4)
    at Object.<anonymous> (offline.js:4)
    at Function.each (offline.js:2)
    at n.fn.init.each (offline.js:2)

Apparently the callback function in helpers.js is called twice: first with data supplied, and secondly without. That second call fails because the callback assumes data to be provided.

Expected behavior:

Steps to reproduce:

Related code:

// insert any relevant code here

Other information:

edsilv commented 6 years ago

I'm a bit confused - helpers.js was introduced in v3 and this bug is in UV v2.0.1?

nicolasfranck commented 6 years ago

So am I ;-)

v2.0.1 is what was reported in bower.json. But I'm sure this is about v3.

m-art-in commented 5 years ago

Some with me, get the error: Cannot set property 'path' of undefined

LlGC-szw commented 1 year ago

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

m-art-in commented 1 year ago

Still open....