UniversalViewer / universalviewer

A community-developed open source project on a mission to help you share your 📚📜📰📽️📻🗿 with the 🌎
http://universalviewer.io
Other
490 stars 184 forks source link

Semantic structure improvements #750

Open edsilv opened 4 years ago

edsilv commented 4 years ago

Use ARIA-landmarks.

H1 is used for download menu (maybe elsewhere), should be h2.

edsilv commented 4 years ago

Make search result "teardrops" and thumbnails buttons so they appear in tab index?

Edit, use buttons.

edsilv commented 4 years ago

"Contents" and "More Information" should be headings with a role="link"

edsilv commented 4 years ago

Make all span tags with class="label" a label

crhallberg commented 4 years ago

I think the highest heading we should use in the UV is h2, under the assumption that the UV will be embedded in a page which will likely use the h1 level.

crhallberg commented 4 years ago

It's also a matter of if we want a flat hierarchy

Navigation
Index
Thumbnails
Image Viewer/PDF Viewer
Search within
Download

or a richer depth

UV/Content viewer
    Navigation
    Content
        Index
        Thumbnails
    Image Viewer/PDF Viewer
    Search within
    Download
demiankatz commented 4 years ago

Definitely interested to hear what @edsilv thinks about this, but I wonder if the flat hierarchy is best for starters because it's simpler and easier to apply consistently, and we can always refine it in future if more subtlety is needed.

edsilv commented 4 years ago

Agree that flat hierarchy sounds good if it's simpler

edsilv commented 4 years ago

Add title to embedding iframe: https://www.w3.org/TR/UNDERSTANDING-WCAG20/ensure-compat-rsv.html

edsilv commented 4 years ago

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA

In HTML5, all ARIA attributes validate. The new landmark elements (

,
,

I think it would be better to use semantic HTML5 instead of ARIA regions?

demiankatz commented 4 years ago

@edsilv, yes, if HTML5 can do the job, don't use ARIA -- it should only be a backup for edge cases where the native support can't fully express the semantics.

LlGC-szw commented 1 year ago

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.