UniversalViewer / universalviewer

A community-developed open source project on a mission to help you share your 📚📜📰📽️📻🗿 with the 🌎
http://universalviewer.io
Other
497 stars 191 forks source link

Regression A/V problem: multiple media files in one canvas #779

Open mcwhitaker opened 3 years ago

mcwhitaker commented 3 years ago

UV version:

https://uv-v3.netlify.app/

I'm submitting a:

Current behavior: We added a link to the UV in the IIIF Cookbook for recipe # 64, Opera in One Canvas. This recipe demonstrates the ability to use one single canvas for multiple A/V files, each using a fragment of the time. Part of approving the process was to demo it, which was done using UV (see recording on minute 38:58).

The link demonstrated in the video no longer works. UV does not play the second file.

Expected behavior: We expected the UV link in the recipe mentioned above to still work.

Steps to reproduce: Go to the recipe, and click on the link View in Universal Viewer and try to navigate to Atto Secondo.

Related code:

// insert any relevant code here

Other information:

glenrobson commented 3 years ago

Has this been fixed? I was just testing the cookbook UV link and the table of contents seems to be working :-).

mcwhitaker commented 3 years ago

Yes, but now the video doesn't show on the viewer? The playhead moves and is correctly showing two files. @glenrobson is the video playing correctly for you?

glenrobson commented 3 years ago

Ah no... you're right I got too carried away with the playhead moving and didn't click play...

edsilv commented 3 years ago

link to manifest: https://uv-v3.netlify.app/#?c=&m=&s=&cv=&manifest=https%3A%2F%2Fiiif.io%2Fapi%2Fcookbook%2Frecipe%2F0064-opera-one-canvas%2Fmanifest.json

markpbaggett commented 2 years ago

Hi @edsilv, the commit above suggests that this issue was fixed, but it still seems to be failing in v3 and v4 of UV. Is this a known issue, or something that has popped back up?

edsilv commented 2 years ago

@markpbaggett This appears to be working in 4.0.1? https://www.universalviewer.dev/#?c=&m=&cv=&xywh=-2494%2C-197%2C7556%2C3936&rid=%5Bobject%20Object%5D&t=11.57800006866455

However, @stephenwf there's a scaling issue with the video where it's overlapping the share and download buttons.

stephenwf commented 2 years ago

Looks like that might be unrelated to video. Fixed inline by removing the style="height: 570px" which doesn't take into account the 20px of padding in the parent on 2 inner elements (.views and .resourcesView > ul)

Screenshot 2022-06-28 at 15 28 54
markpbaggett commented 2 years ago

@edsilv and @stephenwf, hmmmm. I'm still getting the same error in v4.0.1 with the manifest in the recipe:

https://iiif.io/api/cookbook/recipe/0064-opera-one-canvas/manifest.json

Everything is good until we get to the second annotation on the Canvas at 3971.24. The duration keeps going in the viewer, but the second annotation doesn't appear.

I also threw together a quick gist of my own that has the same problem:

https://gist.githubusercontent.com/markpbaggett/f742e2bc857d2e76de8fdcbeb002c3fc/raw/8ac894955c43ce29c26abe2e3241d997f9faab94/wwiioh_2002.json

All is good until we get to the second annotation.

jwd commented 2 years ago

I'm also still seeing the same problem as @markpbaggett with v4.0.1: https://www.universalviewer.dev/#?xywh=-714%2C-197%2C3996%2C3936&iiifManifestId=https%3A%2F%2Fiiif.io%2Fapi%2Fcookbook%2Frecipe%2F0064-opera-one-canvas%2Fmanifest.json

LlGC-szw commented 1 year ago

All issues will be triaged for further investigation or closure by the 28 September 2023. If your issue is still relevant and would like for it be investigated further please comment by 14 September 2023.

edsilv commented 10 months ago

related? https://github.com/pulibrary/figgy/pull/2524/files

markpbaggett commented 8 months ago

@edsilv, I'm not sure if it's related or not, but maybe. It's hard for me to tell what that Figgy fix was doing.

Some other things I noticed: UV seems to be fetching the painting annotation on the second canvas just fine. It shows up on the network tab of a page with the viewer but it doesn't paint it in UV.

Apologies for not providing better feedback or responding sooner.