UniversalViewer / universalviewer

A community-developed open source project on a mission to help you share your 📚📜📰📽️📻🗿 with the 🌎
http://universalviewer.io
Other
490 stars 184 forks source link

UV controls scale improperly for audio manifests without ranges #944

Open benwbrum opened 11 months ago

benwbrum commented 11 months ago

UV version: 4.0.22

I'm submitting a:

Current behavior: When playing a single audio file, users generally want the UV control to be smallish--120-200 pixels high--since there is no video to display and no navigation needed. When loading a IIIF manifest without ranges containing only audio content, the player controls (play, next, volume, etc) scale down to the height of the div, making them appear to be tiny.

Example: Screenshot from 2023-10-24 09-12-09

Expected behavior: The controls should not scale down, but rather appear at the full width of the player.

Steps to reproduce:

Load this manifest in a div sized at 180px: https://saracarl.github.io/comparison-test/her-kind/manifest.json

Related code: According to discussion on UV Slack, this is caused by some special handling for range-less audio content:

Unfortunately, this work-around only works for manifests that contain ranges, so it is not universal.

saracarl commented 11 months ago

So just skipping the media element extension, as in @benwbrum's PR above, introduces CORS issues:

Access to video at 'https://ia601606.us.archive.org/0/items/arrival-beginning/ArrivalBeginning.mp4' from origin 'https://lgsump.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

(This is true for media at multiple sites, including Internet Archive which usually is wide open.)

We're not sure why. Any ideas?

benwbrum commented 6 months ago

The CORS issue above appears to be irrelevant.