UniversalViewer / universalviewer

A community-developed open source project on a mission to help you share your πŸ“šπŸ“œπŸ“°πŸ“½οΈπŸ“»πŸ—Ώ with the 🌎
http://universalviewer.io
Other
491 stars 189 forks source link

Options missing/non-functional in Settings Dialogue for non-OpenSeadragon file formats #956

Open Saira-A opened 8 months ago

Saira-A commented 8 months ago

UV version:

 universalviewer@4.0.25

I'm submitting a:

Current behavior: Currently, if the manifest uses an extension other than OpenSeadragon, the settings dialogue only shows one option, "(Reduce motion (disables animations)", which doesn't work.

Expected behavior: There should be more options in the settings dialogue like there is for manifests using Openseadragon, and they should work.

Steps to reproduce: Click the settings cog for this pdf manifest: https://www.universalviewer.dev/#?xywh=-396%2C-1300%2C11728%2C9815&iiifManifestId=https%3A%2F%2Fdigital.library.villanova.edu%2FItem%2Fvudl%3A294631%2FManifest&cv=&rid=https%3A%2F%2Fadore.ugent.be%2FIIIF%2Fmanifests%2Frange-test%2Franges%2Frange-test%253AR.4

and compare it to OpenSeadragon: https://www.universalviewer.dev/#?xywh=-1793%2C1574%2C6153%2C3936&iiifManifestId=https%3A%2F%2Fwellcomelibrary.org%2Fiiif%2Fb18035723%2Fmanifest&cv=&rid=https%3A%2F%2Fadore.ugent.be%2FIIIF%2Fmanifests%2Frange-test%2Franges%2Frange-test%253AR.4

Also compare what happens when ticking the reduce motion checkbox and then closing the panels - for the pdf example it doesn't make a difference.

Other information:

demiankatz commented 2 months ago

On the July Community Call, there was discussion about the fact that "Reduce motion" only seems to work for the OpenSeadragon left panel, but does not work for other similar things like the left panel in the PDF viewer when using a multi-PDF manifest. @Saira-A spoke to @stephenwf about this on Slack, and he said:

It should work for all modules that are based off of: BaseExpandPanel this.component.publish(BaseEvents.UPDATE_SETTINGS, settings); It's also possible that the other extensions are not listening to this event and re-rendering their own UI.

We should investigate further when time permits.