UniversalViewer / universalviewer

A community-developed open source project on a mission to help you share your 📚📜📰📽️📻🗿 with the 🌎
http://universalviewer.io
Other
500 stars 192 forks source link

3 manifest attributes no longer shown as metadata attributes #973

Open nicolasfranck opened 8 months ago

nicolasfranck commented 8 months ago

UV version:

 universalviewer@4.0.25

I'm submitting a:

Current behavior: Not sure if this a bug, but in UV4 IIIF v2 attributes attribution, license and logo are added to the moreinfo-right-panel as if they were part of the metadata attribute list.

If you provide a IIIF v3 manifest however, with requiredStatement, rights and provider.0.logo, those attributes are NOT added to the list. Is this old behaviour that is considered deprecated? Where should the license/rights be placed?

Expected behavior:

Steps to reproduce:

demiankatz commented 8 months ago

@nicolasfranck, I don't know for certain, but it seems more likely this is due to a lack of support for v3 changes than a conscious decision.

Note that the metadata panel is actually a separate component that gets included here; see: https://github.com/IIIF-Commons/iiif-metadata-component -- I suspect that reviewing that code may reveal the cause, and the solution may be a PR over there and an upgrade here.

(But apologies if I'm incorrect -- I unfortunately don't currently have enough free time to look into this myself, but I hope this proves to be a useful pointer in the right direction).

nicolasfranck commented 8 months ago

@demiankatz Yes I know about that component ;-). I'll give it a try

Notes:

jamesmisson commented 5 months ago

I've adjusted the relevant components (iiif-metadata-component, manifesto and manifold) in a new fork, and the requiredStatement is now included in the metadata here: https://github.com/jamesmisson/manifold

I'll do the logo and license soon. I'm waiting to hear back from the IIIF devs on how this should be incorporated into the main IIIF Commons — then we can bring it over to UV.

jamesmisson commented 1 month ago

Relevant changes to iiif-metadata-component have been merged (https://github.com/IIIF-Commons/iiif-metadata-component/pull/32) so this is now just waiting on a new iiif-metadata-component release.

demiankatz commented 1 month ago

@jamesmisson, do you want to start on that process now, or should we try to get https://github.com/IIIF-Commons/iiif-metadata-component/pull/33 finalized first so we only have to make one release?

I'm fine with either approach -- either waiting until the end, or else doing it once as a learning experience and then quickly repeating it for the second part. :-)