search

Universite-Gustave-Eiffel / I-Simpa

An Open Source software for 3D sound propagation modelling
https://i-simpa.univ-gustave-eiffel.fr/
GNU General Public License v3.0
227 stars 56 forks source link

Tetgen update #275

Closed wbinek closed 3 years ago

wbinek commented 3 years ago

Updates tetgen to latests 1.6 version. New version provides more information on mesh errors I believe it is worth updating. Additionally the new tetgen generates file with skipped faces, so I have added a function to load the skipped faces file in mesh debug mode.

nicolas-f commented 3 years ago

Thanks for the contribution, I will try to build locally in order to check the install

nicolas-f commented 3 years ago

I've switched to ifsttar:dev as I try to put new contributions here and set last release on ifsttar/master

wbinek commented 3 years ago

Ok, great. In future I will make pull requests to dev branch.

Btw. I have the same build problems on appveyor since last week. The issue is most likely caused by CMake update in appveyor image. Temporarily I have switched the appveyor VM to "Previous Visual Studio 2019" and it builds fine.

wbinek commented 3 years ago

Hi! I have just run some more tests on updated version I i have noticed that Tetgen 1.6 does not respect the face area constrain properly. This leads to problems making maps on model surfaces. I have wrote to Tetgen authors and I am waiting for some feedback.

As for now I would recommend reverting this update and leaving it as PR waiting for some fix. Sorry for proposing update to quickly.