search

Universite-Gustave-Eiffel / I-Simpa

An Open Source software for 3D sound propagation modelling
https://i-simpa.univ-gustave-eiffel.fr/
GNU General Public License v3.0
227 stars 56 forks source link

Update swig and wxWidgets #276

Closed wbinek closed 3 years ago

wbinek commented 3 years ago

Switches to using Swig from choco in appveyor build. Currently the 4.0.2 version is downloaded. According to documentation swig 4.0.1 introduced support for Python 3.8 which we are using. Updates wxWidgets to 3.1.5 and fixes deprecation warnings for wxPen and wxBrush styles.

I have tested I-SIMPA with updated libraries for and have not encountered any issues.

nicolas-f commented 3 years ago

I don't know why but know I have the same issue than appveyor on my windows. I'm having a hard time finding a solution

wbinek commented 3 years ago

I don't know what caused a problem. My local builds are fine as well as builds made in appveyor using previous image. I will try to look into it tomorrow.

nicolas-f commented 3 years ago

Maybe its related to an update of visual studio:

Microsoft Visual Studio Community 2019 (2) Version 16.8.2

nicolas-f commented 3 years ago

Its only a warning but it fails, weird warning: target 'C:/Users/kento/Desktop/isimpax64/src/isimpa/$(Configuration)/isimpa.exe' does not exist... CMake Error at C:/Program Files/CMake/share/cmake-3.20/Modules/BundleUtilities.cmake:997 (message): error: fixup_bundle: not a valid bundle Call Stack (most recent call first): cmake_install.cmake:139 (FIXUP_BUNDLE)

wbinek commented 3 years ago

I can't reproduce any of those errors locally. I use Visual Studio Community 16.9.4 with CMake 3.20.1. I have just removed all CMake cache and made clean working directory but I have no CMake or build errors.

nicolas-f commented 3 years ago

Haha found it I created a PR on your side in order to complete this pr