search

Universite-Gustave-Eiffel / NoiseCapture

Android App dedicated to the measurement of environmental noise.
http://noise-planet.org/fr/noisecapture.html
GNU General Public License v3.0
88 stars 45 forks source link

F-Droid inclusion #359

Closed jugendhacker closed 2 years ago

jugendhacker commented 2 years ago

We just received a inclusion request over at F-Droid.

Currently I only see one problem here, please add fastlane structure and tag a new release containing the metadata, so that on our side we don't have so much work maintaining the metadata.

nicolas-f commented 2 years ago

Hi,

It is not from us but it's a welcomed event.

It should not be difficult to add the fastlane folder, juste copy-paste actions..

We currently experience issues with a data over audio library so maybe we will wait to fix it before releasing a new version.

jugendhacker commented 2 years ago

Yeah no problem, just ping me here if you released the new version.

nicolas-f commented 2 years ago

It was published in Beta It will be release in 1 week if there is no new bugs detected

nicolas-f commented 2 years ago

58 has been released and merged in master thank you

jugendhacker commented 2 years ago

Thanks for merging, but seems like you did not properly tag the latest version. Could you please tag it?

nicolas-f commented 2 years ago

Oh yes sorry, I had used the old master branch to create the tag. It's done now I recreated the tag v1.2.22

jugendhacker commented 2 years ago

Okay I finally managed to get our bot looking over it.

Now some new problems appeared. First of all look at the fdroid scanner section and there the errors part. Here we can see that you use mutiple Maven repos that F-Droid does not allow, because it could not be guaranteed that they contain FOSS software. Second you could also see that your repo contains multiple prebuild jars which are usually also not accepted inside F-Droid. I'm not sure but they look like they could maybe be remove before the build on the F-Droid side or will this break something if they are missing during the build?

Also please take a look at the Gradle Wrapper section of the report and follow the hints it gives you.

nicolas-f commented 2 years ago

Sorry for the delay

onomap-geoserver is another project for the server side of the application so it is not embedded into the android application.

Maybe you could scan only the app folder of this repository ?

thanks

jugendhacker commented 2 years ago

Yeah sure if onomap-geoserver folder is not needed for the build of the app we could just nuke it before building.

jugendhacker commented 2 years ago

I'm currently trying to build the app and saw 947a0ef8d57f9c6c5d2e3a3c958783d021f9686f is not included in the v1.2.22 release. We have two possible options now: you could tag another version including this change or if you say it's okay F-Droid could theoretically also build version 1.2.22 from based on 947a0ef8d57f9c6c5d2e3a3c958783d021f9686f, although I would prefer the first option.

nicolas-f commented 2 years ago

If I understand correctly F-Droid is requesting to have the master branch with the last commit always tagged ?

jugendhacker commented 2 years ago

No, we usually build based on the tags. But the commit I linked removes the repo that is not allowed by F-Droid but the v1.2.22 does not include this commit and if I try to build v1.2.22 our buildserver complains about the repo that is not allowed.

nicolas-f commented 2 years ago

I will try to tag without doing an actual release

nicolas-f commented 2 years ago

I release this version: https://github.com/Ifsttar/NoiseCapture/tree/v1.2.22-rc3 With all updates (no change on Android program code)

jugendhacker commented 2 years ago

@nicolas-f sorry to bother you again, but could you maybe comment on https://gitlab.com/fdroid/fdroiddata/-/merge_requests/10732#note_878422774 ?