Universite-Gustave-Eiffel / acoustic-toolbox

A Python library for acousticians.
https://acoustic-toolbox.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Use Rye for package dependencies #24

Closed Nitnelav closed 3 weeks ago

Nitnelav commented 3 months ago

Looks good i'll switch to that !

From what I've red we need to remove requirements.txt and rely on pyproject.toml for dependencies. I believe requirements(-dev).lock files should be committed though

MitchellAcoustics commented 3 weeks ago

@Nitnelav I know we just changed to Rye on my recommendation, but recent updates to uv have integrated the most important features. Rye's documentation notes:

If you're getting started with Rye, consider uv, the successor project from the same maintainers.

While Rye is actively maintained, uv offers a more stable and feature-complete experience, and is the recommended choice for new projects.

So for stability, more documentation, and support, we should probably migrate now while it's still early in our project.

Switching should be very easy, since Rye was using uv behind the scenes anyway and should already be installed for anyone using Rye. I'll get started on it now.

Sorry for being just a little bit early! They released the version of uv with Rye features integrated like a month after I suggested it.

MitchellAcoustics commented 3 weeks ago

Addressed in #31 , waiting for @Nitnelav to make sure he's happy with changing (again) (sorry).

Nitnelav commented 3 weeks ago

ah it broke the read the docs build... I'll check