search

University-Code / uni-code

Site for CS students to practice algorithms
4 stars 4 forks source link

Remove side bar from base.html #12

Closed grunklejp closed 4 years ago

grunklejp commented 4 years ago

We need to change the base.html so that it only contains the top nav bar. Almost every other html doc should extend base.html which we currently cannot do because of the side bar.

A possible solution to this would be to put the side bar into its own template snippet. Thoughts?

kailynw commented 4 years ago

If we use snippets for this it would just be a little harder to find. Because by time we’re done we will probably have like 30 snippets

On Sun, Sep 29, 2019 at 4:29 PM JP notifications@github.com wrote:

We need to change the base.html so that it only contains the top nav bar. Almost every other html doc should extend base.html which we currently cannot do because of the side bar.

A possible solution to this would be to put the side bar into its own template snippet. Thoughts?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/University-Code/uni-code/issues/12?email_source=notifications&email_token=AJ22N5QPHAWBR5GIST46WX3QMEF3XA5CNFSM4I3T5QZ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOM4NTQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ22N5XDUDYJLMNWD45RNYTQMEF3XANCNFSM4I3T5QZQ .

grunklejp commented 4 years ago

That is true. What do you prepose? having multiple base files?

grunklejp commented 4 years ago

I looked at the template docs. We can create a new {% block 'side-bar'%} in the base html doc and go ahead a fill it in with the sidebar. If we make a new page that needs to extend base but doesn't need the side-bar you can just put an empty div in it.

grunklejp commented 4 years ago

Or we just do away with the sidebar altogether.

kailynw commented 4 years ago

Or you can just say include side bar for certain pages. The only places the side bar doesn’t really need to be referenced are places like the login page or something

On Mon, Sep 30, 2019 at 12:07 PM JP notifications@github.com wrote:

Or we just do away with the sidebar altogether.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/University-Code/uni-code/issues/12?email_source=notifications&email_token=AJ22N5SG3W5PS6XT5GMT6HDQMIP33A5CNFSM4I3T5QZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76F6BA#issuecomment-536633092, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ22N5RD7GGFA4RMRF3LFADQMIP33ANCNFSM4I3T5QZQ .