oslfmt
commented
2 years ago Here's a list of issues we need to address. These are all errors, but not criticial. They won't crash the app. The big picture is:
- all solidity (EthersAPI.js) functions need error handling, returning the solidity contract, network, or whatever error to where it can be properly handled
- same for web3storage functions
More specifically:
- nonmember voting -- check if user has NFT, if so either display a msg that they can't vote or disable the buttons altogether
- don't allow duplicate voting --> once vote() has been called, we should move the proposal to the "my votes" section. Or for now we can just disable the voting button afterwards. Easiest is to display an error saying "you've already voted"
- make delegate button more informative --> once successful, relay this information to the user
- submitting a proposal
- propagate any solidity errors to the frontend, displaying them in the UI to the user
- if any IPFS errors, similarly propagate and handle
The simplest strategy for now is put error handling in all the api functions. Then do a simple UI alert to the user about the error and type, along with a suggestion. This can be a simple alert() function call.
In the future, we can take preventative measures with the UI to prevent the errors from even occurring in the first place, such as removing vote buttons, hiding things if no NFT, etc.
Error handling is practically non-existent right now. We'll need someone to devise an error checking plan and then test for errors and then solve them aka "bug hunting". See #54 for more details.