austin-davis1
commented
2 years ago Not sure why the deployment and test scripts are included here, as well as readme and contributing docs...is that supposed to be changed? The artifacts should be added to .gitignore.
Also why were the New_Grant, New_proposal and View_Proposal components deleted?
Besides that, the rest of the new logic looks fine.
Artifacts in src/data are already in gitignore, for some reason there was a duplicate artifacts folder sitting in the api folder that I have now removed. As for the scripts/test/readme stuff, I didn't make any changes to that at all, so I'm not certain where those 'changes' are coming from.
For some reason someone wrote two components for NewProposal, NewGrant, and ViewProposal each. So we had NewProposal, New_Proposal, NewGrant, New_Grant, ViewProposal, and View_Proposal. The deletions I made were removing those duplicates.
In this PR I added banner data to pull from the blockchain, as well as redirection after one submits a proposal. How the new proposal submission flow works is this:
Somebody fills out the title and description fields and clicks submit. The metadata and the ipfs title that we make get pushed into the Redux store. Then, we navigate to a SubmittingProposal component, which is part of the overall app layout. In this component, we pull the metadata and ipfs title from Redux and use them to call the upload function (upload to IPFS) and then subsequently call the propose function (put data on blockchain). This SubmittingProposal function will display a loading symbol if both steps have not been completed. Once they complete, a simple text shows up with a link back to the proposals page.