search

UniversityOfHelsinkiCS / oodikone

An application for analyzing university data
https://oodikone.helsinki.fi
MIT License
14 stars 6 forks source link

[FacultyProgrammeOverview] - Add toggle for `NEW_STUDY_PROGRAMMES` or `ALL_PROGRAMMES` #4555

Closed EssKayz closed 3 months ago

EssKayz commented 5 months ago

FacultyProgrammeOverview had hard coded NEW_STUDY_PROGRAMMES filter for fetching programmes, added a similar toggle from the basic stats view, so that the data can be controller in a similar manner

valtterikantanen commented 5 months ago

A couple of comments:

  1. The old programmes aren't displayed in the progress stats, even if "all programmes" toggle is on (they aren't even included in the numbers so there's something wrong with the calculation)

image

  1. The old programmes aren't displayed in the right place in the first table. They should have the same background color as the other bachelor's/master's programmes. Now they're grouped with doctoral programmes (a probable cause is that the grouping is made based on KH/MH/other programme code)

image

image

EssKayz commented 5 months ago

A couple of comments:

  1. The old programmes aren't displayed in the progress stats, even if "all programmes" toggle is on (they aren't even included in the numbers so there's something wrong with the calculation)

image

  1. The old programmes aren't displayed in the right place in the first table. They should have the same background color as the other bachelor's/master's programmes. Now they're grouped with doctoral programmes (a probable cause is that the grouping is made based on KH/MH/other programme code)

image

image

Hmm... so in other words there's a slight conflict of interest here, since the KH/MH/T only works for HY, but not using KH/MH/T breaks it for HY? Should we instead omit the toggle option, and perform the logic based on serviceProvider ? Optionally, should we first have a look at how to get rid of the KH/MH/T logic and replace it with something based on real urn codes or something similar?

valtterikantanen commented 5 months ago

Hmm... so in other words there's a slight conflict of interest here, since the KH/MH/T only works for HY, but not using KH/MH/T breaks it for HY? Should we instead omit the toggle option, and perform the logic based on serviceProvider ? Optionally, should we first have a look at how to get rid of the KH/MH/T logic and replace it with something based on real urn codes or something similar?

I think updating the logic for determining degree programme "levels" should be number one priority. Currently the logic wouldn't work anywhere outside HY (and even here only with KH/MH codes).

Even if we omit the toggle at HY, some changes to the logic would still be needed and I think it would get really messy really fast. A lot of logic (also in other views) currently relies on this KH/MH separation.