search

UniversityOfHelsinkiCS / oodikone

An application for analyzing university data
https://oodikone.helsinki.fi
MIT License
14 stars 6 forks source link

[CourseStatistics, StudyProgramme, Teachers] Added serviceProvider checks to hide some tables, tabs and routes when not running in toska enviroment #4685

Closed mattirasanen closed 13 hours ago

mattirasanen commented 3 days ago

Added serviceProvider checks to frontend for few views to hide some tables, tabs and routes when not running in toska enviroment.

rundtjan commented 17 hours ago

FD-approved :tm: , but e2e-test failing - might this be flakiness, or is there something actually broken, what says Toska?

valtterikantanen commented 13 hours ago

There was an issue with spreading the toskaColumns array because spreading doesn't clone nested objects. This meant that changes to fdColumns were also affecting toskaColumns. I switched to using cloneDeep from lodash to create a deep copy, and now everything is working properly.