Remove the denormalized feedbackCount from FBT

UniversityOfHelsinkiCS / palaute

Norppa-palautejärjestelmä

https://norppa.helsinki.fi

MIT License

9 stars 7 forks source link

Remove the denormalized feedbackCount from FBT #1227

Open Veikkosuhonen opened 6 months ago

Veikkosuhonen commented 6 months ago

We should instead use the data.feedbackCount in Summary.

[ ] Instead of fbt.feedbackCount, use fbt.summary.data.feedbackCount everywhere.
[ ] Check if need to update sequelize hooks that update the fbt.feedbackCount.
[ ] Remove the fbt.feedbackCount column

HRemonen commented 3 months ago

This will cause further issues with organisation surveys and interim feedbacks which are excluded from the summary object creations in buildSummaries.

This has to be addressed when doing the refactor