UniversityOfHelsinkiCS / palaute

Norppa-palautejärjestelmä
https://norppa.helsinki.fi
MIT License
12 stars 7 forks source link

CourseUnit summary sum row fakd #1323

Closed HRemonen closed 1 week ago

HRemonen commented 4 months ago

The CourseUnit summary sum row is fakd when the "näytä kaikki" is selected from the filters.

The summary average row should calculate the sum of the visible course realisations feedbacks, now it calculates something very different.

The problem

Take for example this CourseUnit:

Image

Why does the average row display that the feedback count is 20 and studentcount is 88 even though there is only one course realisation with the numbers 10/44 correspondingly.

This also gets more interesting when we take some Course with multiple Course realisations:

Image

Where these numbers 496/1598 even comes from? If you sum up the course realisation numbers then 550/964 which means 57% percent of feedbacks given.

This is not the case always

If we filter the summary by "Lukuvuosi" then this is not a issue:

Image

Until there eventually is multiple course realisations:

Image

Like WTF, now the sum row displays the same information as one of the course realisations summary????

HRemonen commented 2 months ago

See also https://github.com/orgs/UniversityOfHelsinkiCS/projects/15?pane=issue&itemId=75291668

HRemonen commented 1 month ago

The TAU changes came and this can't be right. Currently for https://norppa.helsinki.fi/course-summary/TKT20005?startDate=2022-08-01&endDate=2023-07-31 the course summary page is the following:

Image

AFTER THE CHANGES the same page looks like this: Image

Where did the CUR rows disappear?


Also displaying all of the CUR's for a CU does not work anymore. Before: Image

And after the changes: Image