search

UniversityRadioYork / MyRadio

University Radio York's back-end radio management system
https://ury.org.uk/myradio
16 stars 16 forks source link

Set a variable attendee count for demos #1038

Closed cs-endo closed 2 years ago

cs-endo commented 3 years ago

Adds the ability to set an amount of attendees for a training event, making the "max of 2" more variable. Useful for cases when either 1 person is wanted or an arbitrarily large amount of people are wanted.

Also there are slight changes like making a function return early when it (not doing anything else) throws an error and testing if an edited event has a valid date.

Warning: I have not tested this so I don't know if it will work.

michael-grace commented 3 years ago

Looks ok, but I haven't tested it. You're right about removing the else's after throwing the exception, but returning isn't necessary as the exception is thrown

cs-endo commented 3 years ago

That's fair - just playing it safe in that case. I'll try and move this along once we can run myradio locally again

markspolakovs commented 2 years ago

Closing in favour of https://github.com/UniversityRadioYork/MyRadio/pull/1050.