search

UniversityRadioYork / MyRadio

University Radio York's back-end radio management system
https://ury.org.uk/myradio
16 stars 16 forks source link

Adding Nickname's to users and fixing some wordings on user profile to be line with gdpr #1154

Closed hitime1234 closed 3 months ago

hitime1234 commented 3 months ago

Additions: Nicknames - called nnames

Rewording:

-Other minor updates adds comments on what to remove if you want to setup your own mini ury (this is needed as 2016 site expects a mixcloud item)

Thank you for reading this pr, (sorry whoever has to review it) Also sorry for the scuffed ness I am on a train Ren

See pictures below of example changes as tested on my docker cloud

Example of 2016 site after changes: image

Example Myradio changes:

example name nickname changes:

image

image

https://github.com/user-attachments/assets/971646c7-8a0a-41b3-aaf5-bcdf6f13b7a7

Public email changes:

image

LordAro commented 3 months ago

I wonder if "nnames" is really worth the 3 characters you're saving

On Sat, 24 Aug 2024, 17:42 Ren, @.***> wrote:

Additions: Nicknames - called nnames

  • Database new column character varying 255 (can be null)
  • 19.sql patch to allow for upgrades (manual migration must be done)
  • (this has already been completed on ury's version of myradio)

Rewording:

  • In my investigations of trying to fix 2016 site and myradio connections. I stumbled upon a miscommunication that user profiles have the email listed as public obtainable. But isn't called that in the user profile editor.

-Other minor updates adds comments on what to remove if you want to setup your own mini ury (this is needed as 2016 site expects a mixcloud item)

Thank you for reading this pr, (sorry whoever has to review it) Also sorry for the scuffed ness I am on a train Ren

See pictures below of example changes as tested on my docker cloud

Example of 2016 site after changes: image.png (view on web) https://github.com/user-attachments/assets/2de3a919-7ea6-49b3-8165-c098542b5ac2

Example Myradio changes:

example name nickname changes:

image.png (view on web) https://github.com/user-attachments/assets/45e71b5f-0b91-44f1-bc50-45804b767470

image.png (view on web) https://github.com/user-attachments/assets/d6d0c036-9bb8-4864-b8fc-f1d6f847b1fa

https://github.com/user-attachments/assets/971646c7-8a0a-41b3-aaf5-bcdf6f13b7a7

Public email changes:

image.png (view on web) https://github.com/user-attachments/assets/7405d113-8a0a-4164-9ea1-08b40fc22805

You can view, comment on, or merge this pull request online at:

https://github.com/UniversityRadioYork/MyRadio/pull/1154 Commit Summary

File Changes

(22 files https://github.com/UniversityRadioYork/MyRadio/pull/1154/files )

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/UniversityRadioYork/MyRadio/pull/1154, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6SQOGRA44VBPRW7ZWEB4LZTCZZFAVCNFSM6AAAAABNBXKSPWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DINZRGU4DSOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hitime1234 commented 3 months ago

I did think of that. Ultimately wanted keep fname,nname,sname similar so they're a bit more consistent. But I am open to changing to nicknames

ColinRoitt commented 3 months ago

I wonder if "nnames" is really worth the 3 characters you're saving

Would have saved them if you handn't commented this