UnixJunkie / dolog

A dumb OCaml logger
Other
37 stars 7 forks source link

make printf-like functions lazy #9

Closed c-cube closed 10 years ago

c-cube commented 10 years ago

See issue #8 . Some code is duplicated, but not much (logf cannot use log in its implementation). Signatures of printf-like functions use out_channel rather than strings, but overall it doesn't change how the functions are used, and should be more efficient (no intermediate string).

samoht commented 10 years ago

Sweet! Thanks for fixing my ugly code :p

UnixJunkie commented 10 years ago

On 12/30/13, 3:24 AM, Simon Cruanes wrote:

See issue #8 https://github.com/UnixJunkie/dolog/issues/8 . Some code is duplicated, but not much (logf cannot use log in its implementation). Signatures of printf-like functions use out_channel rather than strings, but overall it doesn't change how the functions are used, and should be more efficient (no intermediate string).

Thanks a lot Simon, I'll look carefully at this once I'm back at my office on Monday.


    You can merge this Pull Request by running

git pull https://github.com/c-cube/dolog master

Or view, comment on, or merge it at:

https://github.com/UnixJunkie/dolog/pull/9

    Commit Summary