Closed c-cube closed 10 years ago
Sweet! Thanks for fixing my ugly code :p
On 12/30/13, 3:24 AM, Simon Cruanes wrote:
See issue #8 https://github.com/UnixJunkie/dolog/issues/8 . Some code is duplicated, but not much (logf cannot use log in its implementation). Signatures of printf-like functions use out_channel rather than strings, but overall it doesn't change how the functions are used, and should be more efficient (no intermediate string).
Thanks a lot Simon, I'll look carefully at this once I'm back at my office on Monday.
You can merge this Pull Request by running
git pull https://github.com/c-cube/dolog master
Or view, comment on, or merge it at:
https://github.com/UnixJunkie/dolog/pull/9
Commit Summary
make printf-like functions lazy (with a small code duplication cost, and a change in signatures)
File Changes
- M lib/log.ml https://github.com/UnixJunkie/dolog/pull/9/files#diff-0 (71)
M lib/log.mli https://github.com/UnixJunkie/dolog/pull/9/files#diff-1 (12)
Patch Links:
- https://github.com/UnixJunkie/dolog/pull/9.patch
- https://github.com/UnixJunkie/dolog/pull/9.diff
See issue #8 . Some code is duplicated, but not much (logf cannot use log in its implementation). Signatures of printf-like functions use out_channel rather than strings, but overall it doesn't change how the functions are used, and should be more efficient (no intermediate string).